feat: add to_list and to_pandas api's #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
requested review from
eddyxu,
rok,
westonpace,
wjones127 and
AyushExel
changhiskhan
force-pushed
the
changhiskhan/to_pandas
branch
from
e41223c
to
dad105b
Compare
rok
reviewed
Oct 11, 2023
There was a problem hiding this comment.
There's two more to_dfs here:
lancedb/docs/src/notebooks/multimodal_search.ipynb
Lines 182 to 185 in dad105b
Looks good otherwise.
Edit: nevermind, that's duckdb
| @@ -80,14 +80,14 @@ def handler(event, context): | |||
| # Shape of SIFT is (128,1M), d=float32 | |||
| query_vector = np.array(event['query_vector'], dtype=np.float32) | |||
|
|
|||
| rs = table.search(query_vector).limit(2).to_df() | |||
| rs = table.search(query_vector).limit(2).to_list() | |||
rok
approved these changes
Oct 11, 2023
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
Add `to_list` to return query results as list of python dict (so we're not too pandas-centric). Closes lancedb#555 Add `to_pandas` API and add deprecation warning on `to_df`. Closes lancedb#545 Co-authored-by: Chang She <chang@lancedb.com>
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
add a missing boolean check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
to_listto return query results as list of python dict (so we're not too pandas-centric). Closes #555Add
to_pandasAPI and add deprecation warning onto_df. Closes #545