Exponential standoff retry support for handling rate limited embedding functions #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rok
approved these changes
Nov 1, 2023
rok
reviewed
Nov 1, 2023
| f"Maximum number of retries ({max_retries}) exceeded." | ||
| ) | ||
|
|
||
| delay *= exponential_base * (1 + jitter * random.random()) |
There was a problem hiding this comment.
Average exponent here will be 2.5, so last delay with 10 retries could easily be hours. How about setting default max_retries to 7 so max delay is in tens of minutes?
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
…g functions (lancedb#614) Users ingesting data using rate limited apis don't need to manually make the process sleep for counter rate limits resolves lancedb#579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users ingesting data using rate limited apis don't need to manually make the process sleep for counter rate limits
resolves #579