bug(python): fix path handling in windows #724
Conversation
|
I also found this related bug: #673 (comment) might be worth it to deal with both in the same PR |
python/lancedb/util.py
Outdated
| @@ -84,6 +85,18 @@ def fs_from_uri(uri: str) -> Tuple[pa_fs.FileSystem, str]: | |||
| return pa_fs.FileSystem.from_uri(uri) | |||
|
|
|||
|
|
|||
| def join_uri(base: Union[str, pathlib.Path], *parts: str) -> str: | |||
| """ | |||
| Join a URI with multiple parts, handling extra environment variables. | |||
There was a problem hiding this comment.
"extra environment variables"?
There was a problem hiding this comment.
oops that was generated by copilot and I forgot to change it >_<
|
Oh we don't even have a Windows CI job... |
| """ | ||
| Join a URI with multiple parts, handling extra environment variables. | ||
| """ | ||
| if isinstance(base, pathlib.Path): |
wjones127
force-pushed
the
changhiskhan/windows-path
branch
from
8cdcf53
to
758f024
Compare
|
There seems to already be a test that fails on Windows due to path handling: https://github.com/lancedb/lancedb/actions/runs/7280056572/job/19837672999?pr=729 I have rebased your PR on my PR to add a Windows CI job. |
Use pathlib for local paths so that pathlib can handle the correct separator on windows. Closes #703
changhiskhan
force-pushed
the
changhiskhan/windows-path
branch
from
758f024
to
51c4bfa
Compare
changhiskhan
force-pushed
the
changhiskhan/windows-path
branch
2 times, most recently
from
a463488
to
86e2fab
Compare
changhiskhan
force-pushed
the
changhiskhan/windows-path
branch
from
86e2fab
to
a1fc4bd
Compare
good catch. I added a condition so that if the uri scheme is one letter then just return the uri instead of the netloc + path or path. Lmk if this addresses the cases you've encountered on windows. |
Use pathlib for local paths so that pathlib can handle the correct separator on windows. Closes lancedb#703 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Use pathlib for local paths so that pathlib can handle the correct separator on windows. Closes #703 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Use pathlib for local paths so that pathlib
can handle the correct separator on windows.
Closes #703