-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prompttools + presentation touch ups #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some small things to take a closer look at.
"id": "3babfe5a", | ||
"metadata": {}, | ||
"source": [ | ||
"Next, we create our test inputs. In this case, we would like to create a new ChromaDB collection.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be ChromaDB here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ofc :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
"source": [ | ||
"Next, we create our test inputs. In this case, we would like to create a new ChromaDB collection.\n", | ||
"\n", | ||
"During the experiment, for each embedding function, a new ChromaDB collection will be temporarily created. The documents will be added into it. Then, we will query from it and examine the results." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
@@ -1,5 +1,5 @@ | |||
# VectorDB-recipes | |||
Example Applications | |||
Examples | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add a short description about how these examples are for LanceDB, to get started visit docs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, let's not add lancedb at the top as it'll seem marketing-y..We can add it at the bottom maybe?
Co-authored-by: Tevin Wang <tevin@cmu.edu>
@TevinWang updated the things except the links to lancedb. Let me know if this is good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding prompttools
!
Co-authored-by: Kevin Tse <NivekT@users.noreply.github.com>
No description provided.