Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompttools + presentation touch ups #27

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Add prompttools + presentation touch ups #27

merged 5 commits into from
Aug 17, 2023

Conversation

AyushExel
Copy link
Collaborator

No description provided.

Copy link
Contributor

@TevinWang TevinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small things to take a closer look at.

README.md Outdated Show resolved Hide resolved
"id": "3babfe5a",
"metadata": {},
"source": [
"Next, we create our test inputs. In this case, we would like to create a new ChromaDB collection.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be ChromaDB here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ofc :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"source": [
"Next, we create our test inputs. In this case, we would like to create a new ChromaDB collection.\n",
"\n",
"During the experiment, for each embedding function, a new ChromaDB collection will be temporarily created. The documents will be added into it. Then, we will query from it and examine the results."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@@ -1,5 +1,5 @@
# VectorDB-recipes
Example Applications
Examples

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a short description about how these examples are for LanceDB, to get started visit docs, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, let's not add lancedb at the top as it'll seem marketing-y..We can add it at the bottom maybe?

AyushExel and others added 2 commits August 16, 2023 23:30
Co-authored-by: Tevin Wang <tevin@cmu.edu>
@AyushExel
Copy link
Collaborator Author

@TevinWang updated the things except the links to lancedb. Let me know if this is good to merge

Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding prompttools!

examples/prompttools-eval-prompts/README.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Tse <NivekT@users.noreply.github.com>
@AyushExel AyushExel merged commit dba2280 into main Aug 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants