Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vivaldi browser shows up as Chrome #103

Closed
pokono opened this issue Oct 2, 2015 · 7 comments
Closed

Vivaldi browser shows up as Chrome #103

pokono opened this issue Oct 2, 2015 · 7 comments

Comments

@pokono
Copy link
Contributor

pokono commented Oct 2, 2015

Vivaldi browser shows up as Chrome version 44.
@Nicolas22929
Copy link

User agent example, please?

@ded
Copy link
Collaborator

ded commented Oct 4, 2015

Oh my, as if a spinoff of Opera really needed to happen. Nevertheless, would you mind adding in a sample user agent string?

@pokono
Copy link
Contributor Author

pokono commented Oct 5, 2015

MAC:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.75 Safari/537.36 Vivaldi/1.0.219.53

WINDOWS:
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.75 Safari/537.36 Vivaldi/1.0.219.50

I started putting the headers in this fork but I haven't had the time to finish the job, if it can be of any help it's here:
https://github.com/pokono/bowser/tree/vivaldi-support

Thank you!

@ded
Copy link
Collaborator

ded commented Oct 6, 2015

looks like it's on the right track. Did it pass the tests?

@pokono
Copy link
Contributor Author

pokono commented Dec 7, 2015

@ded I Submitted pull request #119 with all the tests passing. Sorry took so long!

@pokono
Copy link
Contributor Author

pokono commented Dec 7, 2015

@ded Sorry for the mess. I've closed the #119 as it was branched off an old master. I've submitted #120 which passes all the tests.

@lancedikson
Copy link
Collaborator

Merged. Thank you, @pokono 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pokono @ded @lancedikson @Nicolas22929