Handling of Double data type seems not to be correct

[yonojoy]

Given a OpenAPI parameter like this:

      {
        "name": "fee",
        "in": "query",
        "description": "",
        "required": false,
        "type": "number"
      }

the generated code uses the Double data type for Fee. This is than called in the following way:

Request.AddQueryParam('fee', Fee);

with

procedure AddQueryParam(const Name, Value: string);

This does not seem to be correct. The code should not rely on implicit conversion as this will use the system locale.
At least in XE4 this wont even compile.

A resolution would be to have an explicit conversion.

[wlandgraf]

Fixed in 795688a

[yonojoy]

The fix 795688a generates different code for Double params. Instead of

Request.AddQueryParam('fee', Fee);

the new generated code will read:

Request.AddQueryParam('fee', DoubleToParam(Fee));

So my already generated (and modified) code had to be adopted manually. But I think, I will be the only one affected. It is the correct way, to fix the problem.

[wlandgraf]

Yes, it followed the same convention as parameters of type Integer or TDateTime. The conversion should happen in the generated code, it's not the job of AddQueryParam to do type conversion.