-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reference in PriorityFloodFlowDirector #1397
Conversation
…e variables in imshowhs_grid
…ope slopes in line 655.
Thanks @BCampforts! Will you please create a news fragment for the changelog? |
@BCampforts It looks like you removed blank lines from the files you edited. I think, for the most part, we probably want them back—particularly as paragraph separators in the docstrings. |
Yup, working on it |
I added files to the news/ directory, @mcflugen will they be automatically integrated in changelog? |
Yes, they'll be added with the next landlab release. Thanks! |
There seems to be an issue with the notebooks for macos-latest, 3.8. It has to do with the RichDEM package. Can you have a look at this @mcflugen? Thanks! |
…o LS_Runout Pull recent updates from main
…o LS_Runout Pull from remote.
…o LS_Runout Pull recent changes.
…o LS_Runout Pull recent changes.
…o LS_Runout Pull changes
@BCampforts you've removed a lot of blank lines from several files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The main change in this PR is to fix a broken reference in the PriorityFloodFlowDirector where the gradients of the hillslopes are being updated. A second fix is to resolve instabilities related to the use of very small H* values when using the "Space_Large_Scale_Eroder". Some other cosmetic changes and added control on location of ylabels of colorbars in imshowhs_grid function. @mcflugen this is a minor change compared to the previous PR, mainly fixing some minor issues.