Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reference in PriorityFloodFlowDirector #1397

Merged
merged 29 commits into from
Apr 14, 2022

Conversation

BCampforts
Copy link
Collaborator

@BCampforts BCampforts commented Mar 8, 2022

The main change in this PR is to fix a broken reference in the PriorityFloodFlowDirector where the gradients of the hillslopes are being updated. A second fix is to resolve instabilities related to the use of very small H* values when using the "Space_Large_Scale_Eroder". Some other cosmetic changes and added control on location of ylabels of colorbars in imshowhs_grid function. @mcflugen this is a minor change compared to the previous PR, mainly fixing some minor issues.

@mcflugen
Copy link
Member

mcflugen commented Mar 8, 2022

Thanks @BCampforts! Will you please create a news fragment for the changelog?

@mcflugen
Copy link
Member

mcflugen commented Mar 8, 2022

@BCampforts It looks like you removed blank lines from the files you edited. I think, for the most part, we probably want them back—particularly as paragraph separators in the docstrings.

@BCampforts
Copy link
Collaborator Author

Yup, working on it

@BCampforts
Copy link
Collaborator Author

Thanks @BCampforts! Will you please create a news fragment for the changelog?

I added files to the news/ directory, @mcflugen will they be automatically integrated in changelog?

@mcflugen
Copy link
Member

mcflugen commented Mar 8, 2022

I added files to the news/ directory, @mcflugen will they be automatically integrated in changelog?

Yes, they'll be added with the next landlab release. Thanks!

@BCampforts
Copy link
Collaborator Author

There seems to be an issue with the notebooks for macos-latest, 3.8. It has to do with the RichDEM package. Can you have a look at this @mcflugen? Thanks!

@BCampforts
Copy link
Collaborator Author

There seems to be an issue with the notebooks for macos-latest, 3.8. It has to do with the RichDEM package. Can you have a look at this @mcflugen? Thanks!

#1399 solved this. Thanks @mcflugen!

@coveralls
Copy link

coveralls commented Mar 12, 2022

Coverage Status

Coverage increased (+0.02%) to 85.625% when pulling 7216f08 on BCampforts:LS_Runout into 97bb0e2 on landlab:master.

@mcflugen
Copy link
Member

mcflugen commented Mar 18, 2022

@BCampforts you've removed a lot of blank lines from several files. Could you please add them back—particularly in the docstrings where they serve as paragraphs separators? Never mind, I added them back in myself.

Copy link
Member

@mcflugen mcflugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcflugen mcflugen merged commit 7032cd2 into landlab:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants