Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky sediment pulser tests #1794

Merged
merged 3 commits into from Nov 1, 2023
Merged

Fix flaky sediment pulser tests #1794

merged 3 commits into from Nov 1, 2023

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Nov 1, 2023 •
edited

Description

This pull request should fix the flaky tests of the SedimentPulser components. All I've done is added a random seed to each of the pulsers to ensure the tests are reproducible.

Checklist - did you ...

  • Add a news fragment file entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?
  • All tests have passed?
  • Formatted code with black?
  • Removed lint reported by flake8?
  • Sucessful documentation built? (if documentation added or modified)

@coveralls
Copy link

Coverage Status

coverage: 86.432% (+0.01%) from 86.418% when pulling e66e0d4 on mcflugen/fix-flaky-sediment-pulser-tests into 49296a5 on master.

@mcflugen mcflugen added the v2.7 label Nov 1, 2023
@mcflugen mcflugen merged commit 12e8623 into master Nov 1, 2023
@mcflugen mcflugen deleted the mcflugen/fix-flaky-sediment-pulser-tests branch November 1, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v2.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcflugen @coveralls