Can't build strace toy

[frikiluser]

Hi,

I'm not able to build allyesconfig since this commit d62ee37 due to undefined reference to xfork error.

I'm using Debian-amd64 based system.

Best regards,

[enh-google]

patch sent to mailing list. just a #if in portability.c that should have been a #ifdef... though i'm not sure why none of the other references to xfork() caused this.

[landley]

All the other references to xfork were in commands with depends on TOYBOX_FORK intheir config, because allyesconfig enables TOYBOX_FORCE_NOMMU and thus disables fork(). The CFG_XXX macros are always #defined (to either 0 or 1, so they can be used in if(blah) tests to trigger dead code elimination), so using #ifdef instead of #if to test them will always return "true".

The proper fix is to change this xfork() into an XVFORK() which should work but I want to think through it and test it (I haven't actually tried the strace in pending at all yet), which bumps it to this weekend? (Yes, it should theoretically be possible to implement an strace with nommu support...)

[enh-google]

Note that there are a bunch of *other* direct xfork() calls (including the one I copy-and-pasted the strace one from), so I assume you'll need to change them all to make this go away.

…

On Wed, Oct 27, 2021, 22:46 Rob Landley ***@***.***> wrote: All the other references to xfork were in commands with depends on TOYBOX_FORK intheir config, because allyesconfig enables TOYBOX_FORCE_NOMMU and thus disables fork(). The CFG_XXX macros are always #defined (to either 0 or 1, so they can be used in if(blah) tests to trigger dead code elimination), so using #ifdef instead of #if to test them will always return "true". The proper fix is to change this xfork() into an XVFORK() which should work but I want to think through it and test it (I haven't actually tried the strace in pending at all yet), which bumps it to this weekend? (Yes, it should theoretically be possible to implement an strace with nommu support...) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#298 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMVLEWBEXFOOQEVGL7OPJ3LUJDPUBANCNFSM5G2I4OQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[frikiluser]

As mentioned before, it fixes the reported problem 👍🏾

CONFIG_TOYBOX_FORK=y
CONFIG_TOYBOX_FORCE_NOMMU=n

[landley]

Alas, it's still in pending for a reason...