Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In mkroot: Combination of CROSS= and NOLOGPATH= breaks PATH #343

Closed
natecain opened this issue May 11, 2022 · 3 comments
Closed

In mkroot: Combination of CROSS= and NOLOGPATH= breaks PATH #343

natecain opened this issue May 11, 2022 · 3 comments

Comments

@natecain
Copy link

Command: ./scripts/mkroot.sh dropbear CROSS=aarch64 NOLOGPATH=1 V=s

Expectation: Root is built with a cross-compiled dropbear, the same as if NOLOGPATH had not been specified

Result: cross compiler is not seen in path. Configure for dropbear detects and uses host compiler, resulting in a build with the host compiler. Then ${CROSS_COMPILE}strip dropbearmulti fails with /home/user/toybox/ccc/aarch64-linux-musleabi-cross/bin/aarch64-linux-musleabi-strip: Unable to recognise the format of the input file 'dropbearmulti'

Mitigation: compiling without NOLOGPATH specified seems to always work correctly

@landley
Copy link
Owner

landley commented May 14, 2022

Commit 43f61a6

@landley
Copy link
Owner

landley commented May 14, 2022

Did you know that if you write a commit with a hash while the push is still ongoing in another window so github doesn't turn the hash into a link, that if you edit and re-save the comment after the push completes it STILL doesn't turn it into a link?

I break everything.

@landley
Copy link
Owner

landley commented Jun 2, 2022

In the absence of follow-up, I'm assuming the commit above fixed the issue.

@landley landley closed this as completed Jun 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants