Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you include oksh? #501

Closed
ghost opened this issue May 18, 2024 · 1 comment
Closed

Can you include oksh? #501

ghost opened this issue May 18, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented May 18, 2024

The default sh of toybox is too limited. OpenBSD's ksh is very portable and is better compatible with bash.

https://github.com/ibara/oksh

@landley
Copy link
Owner

landley commented May 18, 2024

The command isn't finished (which is why it's in pending), so we should abandon the unfinished implementation and replace it with an external project? You can already build that project and install it alongside toybox.

It is interesting that oksh is public domain, but toysh has the goal of providing a drop-in bash replacement which that doesn't seem to. I checked out and a copy and "cat oksh/*.c | wc" gives me about ~25k lines, and toysh so far is around 5k lines.

And then there's the "mayfork" commands, which need to exist both standalone and provide shell builtin versions with extra behavior. For example, "which kill" has a version you can call out of the path, but "kill %1" integrates with shell job control. Currently, this is done with the toybox MAYFORK plumbing, which an external project won't have and won't integrate easily with.

@ghost ghost closed this as completed May 19, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant