Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semicolon following GLOBALS macro in the few commands that had one, as well as unneeded semicolons following one line cp functions #214

Closed
wants to merge 5 commits into from

Conversation

E5ten
Copy link
Contributor

@E5ten E5ten commented May 29, 2020

These cause a -Wextra-semi (if it is enabled) warning for every inclusion of globals.h, due to a double-semicolon following the structs for these commands' global variables. Remove the unnecessary semicolons.

@E5ten E5ten changed the title Remove semicolon following GLOBALS macro in the few commands that had one Remove semicolon following GLOBALS macro in the few commands that had one, as well as unneeded semicolons following one line cp functions May 30, 2020
@landley
Copy link
Owner

landley commented May 31, 2020

Does this change actually accomplish anything?

@enh-google
Copy link
Collaborator

...it would mean i have no chance of winning the pedantry award for 0.8.4 :-)

@landley
Copy link
Owner

landley commented Apr 1, 2023

Commit f9acf3b

@landley landley closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants