profile: Added comments and a finally functioning profile loader. #4
Conversation
This first version is really basic. It just loads a profile based on the command name located in ~/.config/file_<cmd>.ll. The file format is also very basic, it is essentially just like dotenv files: a succession of environment variable declaration. The only thing "smart" about it for now is that it merges them before passing them to the sandboxer. Note: I included code in the comments much like for a normal crate. However, it seems like code in the comments of examples are not currently being executed anywhere: rust-lang/cargo#4508
| /// ``` | ||
| /// let paths = parse_path_list("/usr/lib:/bin:/tmp"); | ||
| /// | ||
| /// assert_eq!(paths, Ok("", vec!["/usr/lib", "/bin", "/tmp"])); |
There was a problem hiding this comment.
If it is not taken into account by cargo test then it should be in tests. Most of functions from this file should be tested.
|
|
||
| let profile = parse_profile(&profile); | ||
| // TODO: no more hardcoding | ||
| let mut sandboxer = Command::new("./target/release/examples/sandboxer"); |
There was a problem hiding this comment.
Why not reuse the code from the sandboxer as a library? In fact, it would avoid creating a custom dotenv-like parser. This could be replaced with a proper configuration format (e.g. TOML) that could also simplify the code and enable a more extensible configuration.
I'm working on a version of add_rule() that takes a Rule iterator as argument. This would help simplify and reuse the sandboxer code.
|
This new application should probably be hosted in a dedicated repository. I'll probably keep the sandboxer example as an example that can be used to help users, but let's focus on the original goal: a library. :) |
This first version is really basic. It just loads a profile based on the
command name located in ~/.config/file_.ll.
The file format is also very basic, it is essentially just like dotenv
files: a succession of environment variable declaration. The only thing
"smart" about it for now is that it merges them before passing them to
the sandboxer.
Note: I included code in the comments much like for a normal crate.
However, it seems like code in the comments of examples are not
currently being executed anywhere: rust-lang/cargo#4508