Update Drupal 9 recipe to PHP 8.0 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Use PHP version 8.0 or higher for current release versions of Drupal 9. Drupal 10 is planned to require PHP 8. From Drupal 9 [PHP requirements](https://www.drupal.org/docs/system-requirements/php-requirements).
|
I would do 8.0 for now as 8.1 is fairly new and there are still some extensions that don't work with it. @cabagach |
|
Yeah, probably best to be safe, I have updated the version to |
cabagach
changed the title
|
@cabagach looks like you need to update the tests too since it is looking for php 7.4: https://github.com/lando/cli/tree/main/examples/drupal9 |
|
Thanks for the fast response @labboy0276, and also for helping me make the test pass. |
|
No problem, it will be in the next release of Lando @cabagach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Drupal 9 PHP requirements.