Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lando setup fails on Windows if docker-users does not already exist #116

Closed
AaronFeledy opened this issue Feb 25, 2024 · 1 comment · Fixed by #124
Closed

lando setup fails on Windows if docker-users does not already exist #116

AaronFeledy opened this issue Feb 25, 2024 · 1 comment · Fixed by #124
Assignees
Labels
bug Something isn't working

Comments

@AaronFeledy
Copy link
Member

On a fresh Windows machine, running lando setup installs Docker Desktop and also checks for the docker-users user group. There seems to be a race condition here where the check for the user group can happen before Docker is installed. This causes the setup to crash with Could not determine group situation.

@pirog
Copy link
Sponsor Member

pirog commented Mar 1, 2024

i can replicate this, did not see it previously because i only removed my user from docker-users and it is NOT removed by uninstalling docker desktop, you need to manually remove the group.

@pirog pirog self-assigned this Mar 1, 2024
@pirog pirog linked a pull request Mar 1, 2024 that will close this issue
@pirog pirog closed this as completed in #124 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants