Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overrride COLUMNS #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't overrride COLUMNS #179

wants to merge 1 commit into from

Conversation

AaronFeledy
Copy link
Collaborator

In recent years, Docker has improved its handling of terminal dimensions and no longer defaults to 80 columns. It uses the actual width of the user's terminal. As of Docker CLI v23 released last year, there are no more gaps in functionality on this. Lando no longer needs to hard code this value to force wider output as this is fully managed by Docker. Leaving it in only introduces problems with interactive and dynamically updated TUIs.

Resolves lando/lando#1847

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for lando-core ready!

Name Link
🔨 Latest commit f900799
🔍 Latest deploy log https://app.netlify.com/sites/lando-core/deploys/6675bfc5100aed0008455139
😎 Deploy Preview https://deploy-preview-179--lando-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to change COLUMNS environment variable?
1 participant