Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarization and other signing problems #2037

Closed
3 of 4 tasks
pirog opened this issue Mar 12, 2020 · 1 comment
Closed
3 of 4 tasks

Notarization and other signing problems #2037

pirog opened this issue Mar 12, 2020 · 1 comment
Assignees
Labels
devops Issue deals with lando devops eg build, test or deploy macos Deals specifically with macos windoze Deals specifically with Windoze
Milestone

Comments

@pirog
Copy link
Sponsor Member

pirog commented Mar 12, 2020

We are now blocked from our next release because macOS notarization is now smart enough to see that our binary is not signed correctly. This is due to an upstream bug in pkg
vercel/pkg#128

Going to create this issue so we can track that but also going to wrap in

  • Upgrade to node 12
  • Get Windows things signed
  • Upgrade hyperdrive?
  • Update travis certs
@pirog pirog added devops Issue deals with lando devops eg build, test or deploy macos Deals specifically with macos windoze Deals specifically with Windoze labels Mar 12, 2020
@pirog pirog added this to the 3.0.0-aft.1 milestone Mar 12, 2020
@pirog pirog self-assigned this Mar 12, 2020
pirog added a commit that referenced this issue Mar 13, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
@pirog pirog closed this as completed Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 14, 2020
pirog added a commit that referenced this issue Mar 17, 2020
@saurabh-deep
Copy link

Hey @pirog! Were you able to proceed with the signing of Mac OS binary created with pkg? Which version of Node js you ended up with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Issue deals with lando devops eg build, test or deploy macos Deals specifically with macos windoze Deals specifically with Windoze
Projects
None yet
Development

No branches or pull requests

2 participants