Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lagoon] Use environment name for lando pull/push commands #2685

Closed
thom8 opened this issue Nov 10, 2020 · 1 comment
Closed

[lagoon] Use environment name for lando pull/push commands #2685

thom8 opened this issue Nov 10, 2020 · 1 comment
Assignees
Labels
bug Something aint working right! lagoon Deals with the Lagoon recipe

Comments

@thom8
Copy link

thom8 commented Nov 10, 2020

Currently lando pull uses branch names to select the environment to pull from however environment aren't always directly linked to branches so using environment names would be best in this situation.

Can we update the lando pull command for lagoon recipes to select the environment name to pull from for database and files?

For extra points it would be great to support the environment global unique name [lagoon-project]-[environment-name] as well as just providing the environment name as the project would be known in the context of the command. The following examples should ideally all be possible for the best UX:

1. lando pull --database [environment-name]
2. lando pull --database [lagoon-project]-[environment-name]
3. lando pull --database @lagoon.[lagoon-project]-[environment-name]
@thom8 thom8 added the bug Something aint working right! label Nov 10, 2020
@pirog pirog added the lagoon Deals with the Lagoon recipe label Nov 10, 2020
@mikemilano
Copy link
Contributor

I added support for cases 1 and 2;

3 was a little more complicated and the @ sign is more of a dush execution symbol rather than the alias. Let's discuss, and if that format is still required, we can spend more time on it.

pirog added a commit that referenced this issue Nov 10, 2020
#2685 Lagoon pull/push support for multiple env name formats
@pirog pirog closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right! lagoon Deals with the Lagoon recipe
Projects
None yet
Development

No branches or pull requests

4 participants