Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lando push with Lagoon does not respect the configured Drupal public file path #3060

Closed
owenbush opened this issue Jun 25, 2021 · 0 comments · Fixed by lando/cli#11
Closed
Labels
bug Something aint working right! lagoon Deals with the Lagoon recipe
Projects

Comments

@owenbush
Copy link
Contributor

owenbush commented Jun 25, 2021

Tell us about your setup

What is your lando version and operating system?

v3.1.4 on Mac OSX 11.4 (Big Sur)

Tell us about your .lando.yml

name: drupal-example-3
recipe: lagoon
config:
  flavor: drupal
  build:
    - composer install

Tell us about the command you were running

lando push

Tell us about the error you got

Drupal allows users to configure where their public file system should live, Drupal can also have the core code live in any directory (although web has become the defacto standard webroot). The current Lagoon integration assumes that the public file path is web/sites/default/files when in reality it could be anything.

We addressed this issue with lando pull a while ago in #2762 and at the time I promised myself I would return to handle the lando push side of things. Here I am now.

Tell us generally about your bug

In issue 2762 we switched to using drush dd files to determine the defined path for files, and to use that in the Drush command instead.

@owenbush owenbush added the bug Something aint working right! label Jun 25, 2021
@pirog pirog added the lagoon Deals with the Lagoon recipe label Jun 30, 2021
@pirog pirog added this to New issues in Lagoon via automation Jun 30, 2021
Lagoon automation moved this from New issues to Done Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right! lagoon Deals with the Lagoon recipe
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants