Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to control switches #23

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

lmatter
Copy link
Contributor

@lmatter lmatter commented Nov 9, 2022

switch is a reserved word, so I spelled the iterator swytch.

@landonr
Copy link
Owner

landonr commented Nov 9, 2022

nice work! this fixes #22

  1. can we use switchObject instead of swytch to keep everything plain english?
  2. the linter didnt run but I got a warning in esphomeRemote.h for an unhandled switchesMenu in a switch statement
  3. can you add an example to the sharedRemoteConfig.yaml like
 ## Home assistant switches. Set with a friendly name
 - lambda: |-
     std::vector<FriendlyNameEntity> switches { 
       FriendlyNameEntity("switch.oven_fan", "Oven Fan")
     };
     switchGroup = new SwitchGroupComponent(displayUpdate);
     switchGroup->setup(switches);
     return {switchGroup};
   id: switch_group_component```

@landonr landonr merged commit e67aebf into landonr:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants