Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config examples #28

Merged
merged 13 commits into from
Nov 18, 2022
Merged

Config examples #28

merged 13 commits into from
Nov 18, 2022

Conversation

Carunga
Copy link
Contributor

@Carunga Carunga commented Nov 17, 2022

Added examples to the docs of the config bits I could not figure out myself. And added the player state "off". I failed to do that as an own pull request.

@landonr
Copy link
Owner

landonr commented Nov 17, 2022

cool the "off" stuff helps with LG webos tvs but I don't think we can close #26 yet

i think the branch is failing because you added spaces instead of tabs (or the opposite). if you click on the details of the failed check you can see it's trying to remove and add the same line here

-      mediaArtist = "";     
+      mediaArtist = "";

@Carunga
Copy link
Contributor Author

Carunga commented Nov 17, 2022

tried again, copied directly from the lines above, same result.

#26 cannot be closed, no. in my install i changed the command names. a more generic solution might be beyond what i can do.

@landonr
Copy link
Owner

landonr commented Nov 17, 2022

can you try running clang-format esphomeRemote/*.h --style=file:.clang-format --i

@landonr
Copy link
Owner

landonr commented Nov 18, 2022

yes brotherman!

@landonr landonr merged commit 88260ae into landonr:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants