Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webfinger's restrictions removed because optionals in specs #35

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Webfinger's restrictions removed because optionals in specs #35

merged 1 commit into from
Jul 5, 2023

Conversation

Simounet
Copy link
Contributor

@Simounet Simounet commented Jul 5, 2023 •
edited
Loading

See https://datatracker.ietf.org/doc/html/rfc7033#page-11
Subject set at SHOULD but not at MUST so it can be controversial. The others are OPTIONAL.

@landrok
Copy link
Owner

landrok commented Jul 5, 2023

Hello @Simounet ,
first, thanks for your interest and great PRs today :)
This PR seems to fail due to some missing methods. As you patch these ones in your #33 PR.
Could you merge updated master branch with this branch please ?

Regards,
landrok

@Simounet Simounet force-pushed the fix/webfinger-optional-attributes branch from 3e6dfe3 to 3f1a7af Compare July 5, 2023 17:23
@Simounet
Copy link
Contributor Author

Simounet commented Jul 5, 2023

Hi,
You're welcome! I rebased then push force. Seems to be okay. I'm working on a new activitypub project and your package is a breath!
Could be great to implement an expected level configuration for MUST, SHOULD, MAY, OPTIONAL key words. This version is very opinionated.

@landrok landrok mentioned this pull request Jul 5, 2023
Open
@landrok
Copy link
Owner

landrok commented Jul 5, 2023

Yes, cherry picks, it could be some interesting options. I opened an issue to keep that in mind. Feel free to add some use cases.

@landrok landrok self-assigned this Jul 5, 2023
@landrok landrok added the enhancement New feature or request label Jul 5, 2023
@landrok landrok merged commit 261716a into landrok:master Jul 5, 2023
4 checks passed
@Simounet Simounet deleted the fix/webfinger-optional-attributes branch July 5, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@landrok landrok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Simounet @landrok