Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prospector installs django when django is not detected as requirement #245

Closed
JensTimmerman opened this issue Mar 8, 2018 · 2 comments
Closed

prospector installs django when django is not detected as requirement #245

JensTimmerman opened this issue Mar 8, 2018 · 2 comments

Comments

@JensTimmerman
Copy link

JensTimmerman commented Mar 8, 2018 •
edited

Since pylint-django added django as a requirement, and pylint-django is a requirement of prospector, django is pulled in for all tests that use prospector. (pylint-dev/pylint-django#132)

Even though requirements detector does not detect anything django related, pytlink-django is installed, which in turn installs django (which fails on python 2.7 if you don't specify django 1.11)
@JensTimmerman JensTimmerman mentioned this issue Mar 8, 2018
Merged
@chocoelho
Copy link
Contributor

IMHO, prospector shouldn't install pylint plugins such as pylint-celery, pylint-django and pylint-flask, since this should be handled through each project pylint configuration (meaning inside pylintrc).

@chocoelho chocoelho mentioned this issue Apr 20, 2018
Merged
@JensTimmerman
Copy link
Author

JensTimmerman commented May 23, 2018 •
edited

seems to be fixed by pylint-dev/pylint-django#137

@JensTimmerman JensTimmerman mentioned this issue May 23, 2018
Merged
@carlio carlio mentioned this issue Nov 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JensTimmerman @chocoelho