Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pylint and ignore error from removed rule #406

Closed
wants to merge 4 commits into from
Closed

Update pylint and ignore error from removed rule #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9117129
Update pylint and ignore error from removed rule
EvgeneOskin Feb 25, 2021
4cbd86e
Install updated py to fix safety ID 39253
EvgeneOskin Feb 26, 2021
e5832f6
Update pylint to 2.7.2
EvgeneOskin Mar 1, 2021
be1f023
Drop python 3.5 support because of astroid 2.5.1
EvgeneOskin Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
dist: xenial # required for Python >= 3.7
language: python
python:
- "3.5"
- "3.6"
- "3.7"
- "3.8"
Expand All @@ -11,7 +10,7 @@ matrix:
- python: "nightly"
install:
- "pip install --editable .[with_everything]"
- "pip install safety pipenv numpy tzlocal nose coverage coveralls -U"
- "pip install safety pipenv numpy tzlocal nose coverage coveralls py -U"
- "pip freeze | safety check --stdin"
script:
- "nosetests -s --with-coverage --cover-inclusive --cover-package=prospector tests/"
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ handling the output of other tools. However, please do run them before submittin

nosetests tests/

Prospector targets Python 2.7, 3.4, 3.5, 3.6, 3.7 and 3.8. You can use `tox`_ to test this locally,
Prospector targets Python 2.7, 3.6, 3.7 and 3.8. You can use `tox`_ to test this locally,
and all tests are run on `travis-ci.org`_.

.. _tox: https://tox.readthedocs.io/en/latest/
Expand Down
2 changes: 1 addition & 1 deletion docs/contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ handling the output of other tools. However, please do run them before submittin

nosetests tests/

Prospector targets Python 3.5, 3.6, 3.7 and 3.8. You can use `tox`_ to test this locally,
Prospector targets Python 3.6, 3.7, and 3.8. You can use `tox`_ to test this locally,
and all tests are run on `travis-ci.org`_.

.. _tox: https://tox.readthedocs.io/en/latest/
Expand Down
2 changes: 1 addition & 1 deletion prospector/tools/pylint/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _prospector_configure(self, prospector_config, linter):
# allow the indentation specified in the pylint configuration file; we
# replace it instead with our own version which is more lenient and
# configurable
linter.disable("mixed-indentation")
linter.disable("mixed-indentation", ignore_unknown=True)
indent_checker = IndentChecker(linter)
linter.register_checker(indent_checker)

Expand Down
9 changes: 4 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
exec(f.read())
_VERSION = globals()["__version__"]

if sys.version_info < (3, 5):
raise Exception("Prospector %s requires Python 3.5 or higher." % _VERSION)
if sys.version_info < (3, 6):
raise Exception("Prospector %s requires Python 3.6 or higher." % _VERSION)


_PACKAGES = find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"])
Expand All @@ -30,9 +30,9 @@
"pycodestyle<2.7.0,>=2.6.0",
"pep8-naming>=0.3.3,<=0.10.0",
"pydocstyle>=2.0.0",
"pylint==2.5.3",
"pylint==2.7.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pylint==2.7.2",
"pylint==2.8.3",

astroid is pinned to 2.5.6 in pylint 2.8.3 and will stay pinned in future versionso I don't know what to do with the astroid version line 35, but the easiest would be to use pylint's version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional comment - is there any specific reason that prospector is pinning 2.8.3/2.7.2? It seems like prospector is pretty widely compatible, so it might increase user flexibility to unpin asteroid, and change the pylint version to something like:

pylint>=2.5.3,<2.9

This would increase user flexibility, allowing users requiring a fixed pylint/asteroid version to specify exactly (unless there are actually breaking changes).

"pylint-django<2.2.0",
"astroid==2.4.1",
"astroid==2.5.1",
]


Expand All @@ -46,7 +46,6 @@
"Intended Audience :: Developers",
"Operating System :: Unix",
"Topic :: Software Development :: Quality Assurance",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py35,py36,py37,py38
envlist = py36,py37,py38

skip_missing_interpreters = true

Expand Down