Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple positional path arguments #78

Merged
merged 2 commits into from Jan 2, 2015

Conversation

guykisel
Copy link
Contributor

This replaces #68. Instead of modifying Prospector to support multiple paths, I've modified prospector.run.main to create a new Prospector instance for each input path.

Detailed changes:

  • If more than one path is provided and one of the paths is a directory, raise a ValueError
  • Explain multi-input directory restriction in --help
  • Add Path to each summary
  • Don't print Messages header if there are no messages

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.15%) when pulling 56ce6fa on guykisel:multi-path-input into 1aaa0d6 on landscapeio:develop.

@carlio carlio merged commit 56ce6fa into landscapeio:develop Jan 2, 2015
carlio added a commit that referenced this pull request Jan 2, 2015
… new configuration manager introduced in #74 and #10
@carlio
Copy link
Member

carlio commented Jan 2, 2015

Thanks! In the end I had to jiggle things around a bit to get it to work with the configuration changes I had made elsewhere, but actually it ended up being a bit simpler - the Prospector object can now handle being given multiple paths instead of having to create a new object each time.

carlio added a commit that referenced this pull request Jan 2, 2015
carlio added a commit that referenced this pull request Jan 2, 2015
@guykisel guykisel deleted the multi-path-input branch January 2, 2015 16:51
@guykisel
Copy link
Contributor Author

guykisel commented Jan 2, 2015

Nice! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants