Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetection library bugfixes, closes #82, #83 #85

Merged
merged 4 commits into from
Jan 4, 2015
Merged

Autodetection library bugfixes, closes #82, #83 #85

merged 4 commits into from
Jan 4, 2015

Conversation

jquast
Copy link
Contributor

@jquast jquast commented Jan 4, 2015

  • resolves regression in adapter library detection raising, ValueError: too many values to unpack
  • resolves regression when adapter library detects django, TypeError: '_sre.SRE_Pattern' object is not iterable

new test case brings prospector.autodetect from 75% coverage to 92%.

Also, use command ``nosetests tests``; otherwise nose walks
the module path prospector/ looking for tests, which may
raise ImportError for tools like vulture & friends that
are ``_OPTIONAL`` and not installed into the test environment.
* resolves regression in adapter library detection raising, ``ValueError: too many values to unpack``
* resolves regression when adapter library detects django, ``TypeError: '_sre.SRE_Pattern' object is not iterable``
My local machine discovers django, but travis-ci is the
project's test-case source of truth, so adjust test
accordingly.  (I don't use django so I don't know why it
would effect my environment differently ...)
@landscape-bot
Copy link

Code Health
Repository health increased by 1% when pulling 07e41c3 on jquast:prospector into 0fd631e on landscapeio:prospector.

@carlio
Copy link
Member

carlio commented Jan 4, 2015

Thanks for this, I'll push a 0.8.2 release onto PyPI now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants