Help center translations API #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Since Zendesk2::Request#find! calls .to_i on hash keys, we need an integer | ||
| # key for this. | ||
| key = [source_type, source_id, locale].join("-").each_byte.inject(0) {|char, acc| acc + char } |
There was a problem hiding this comment.
we should either pull this function up or lift the to_i restriction on find!
There was a problem hiding this comment.
I seem to recall the to_i restriction was because of people using :symbol and "text" keys for the service.data hash? I'll pull this into a class method.
https://developer.zendesk.com/rest_api/docs/help_center/translations Translations API to update article title & body, section title and category title.
Typo in categories URL. Allow filtering with `locale` or `locales` arguments when listing translations
Extracted out the shared methods in various request classes to the `TranslationSource` module. Also pulled out the `source=` method into the module.
Check if the params has the `translations` key when looking for `source_id` and `source_type`. If it doesn't then look at the root of the params for the attributes. This way we can reuse the module for all our translation requests.
omgitsads
force-pushed
the
help-center-translations
branch
from
0514c07
to
3e149e0
Compare
|
@omgitsads cheers 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.zendesk.com/rest_api/docs/help_center/translations
Translations API to update article title & body, section title and
category title.