Fix possible freeze when downloading avatars

Fixes gitextensions#5859
lanfeust69 · Dec 8, 2018 · 7ebe98c · 7ebe98c
1 parent fca7cf2
commit 7ebe98c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/GitUI/Avatars/AvatarDownloader.cs b/GitUI/Avatars/AvatarDownloader.cs
@@ -152,7 +152,11 @@ async Task<Image> Download()
                         {
                             webClient.Proxy.Credentials = CredentialCache.DefaultCredentials;
 
-                            using (var imageStream = await webClient.OpenReadTaskAsync(imageUrl))
+                            // actually, due to a .Net FX bug, WebClient.OpenReadTaskAsync *can* block before returning a Task
+                            // let's make sure this doesn't happen on the current thread (likely the UI thread)
+                            var readTask = Task.Run(() => webClient.OpenReadTaskAsync(imageUrl));
+
+                            using (var imageStream = await readTask)
                             {
                                 return Image.FromStream(imageStream);
                             }