add database.all #159
Closed
add database.all #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langalex
reviewed
Aug 1, 2023
| def first!(spec) | ||
| first(spec) || raise(CouchPotato::NotFound) | ||
| end | ||
|
|
||
| # returns all instances for a model | ||
| def all(model) | ||
| spec = CouchPotato::View::ModelViewSpec.new(model, 'all_model_instances', {}, {}) |
| def first!(spec) | ||
| first(spec) || raise(CouchPotato::NotFound) | ||
| end | ||
|
|
||
| # returns all instances for a model | ||
| def all(model) | ||
| spec = CouchPotato::View::ModelViewSpec.new(model, 'all_model_instances', {}, {}) |
There was a problem hiding this comment.
having one view per model is wasteful. imagine having 200 models. you could have one view where the model class is part of the key and use that to filter results.
the original inspiration was a model like (but not exactly, I forgot which it was) SpaceProfile, which doesn't have any views attached to it directly, and / or totally orphanaged models like some payment notification, where it would have been useful in support to just look at all of them and then filter for some attribute. Or maybe we can already do this and I'm just missing the correct syntax? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a database.all method that makes it possible to find e.g. all Invoices by saying db.all(Invoice).
To be used for debugging / finding records in one-off ways that don't warrant building a new view.
Note
the failing specs (for jruby, active_support_6_0) didn't start failing in this commit but earlier, in commit a185a80