Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive fixes for 34 #36

Merged
merged 1 commit into from
Mar 21, 2017
Merged

responsive fixes for 34 #36

merged 1 commit into from
Mar 21, 2017

Conversation

weyj4
Copy link

@weyj4 weyj4 commented Mar 15, 2017

@wbprice @yejodido you guys merge if you're happy with these changes.

@weyj4 weyj4 mentioned this pull request Mar 15, 2017
@tjwebb tjwebb requested review from wbprice and nogtini March 15, 2017 21:36
</ul>
</div>
<div className="contact-info">
<h2><i className={'icon-mail'} /><a href="mailto:hello@langa.io">hello@langa.io</a></h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The items under contact information should not be wrapped in h2 tags. Something like:

<section>
    <h2>Contact Information</h2>
    <ul>
        <li><a href="#"><i className="icon-mail" /> Email</a></li>
        <li><a href="#"><i className="icon-phone" />(757) 828-7656</a></li>
    </ul>
</section>

would be more correct.

@wbprice
Copy link

wbprice commented Mar 16, 2017

screen shot 2017-03-15 at 10 00 46 pm

In the contact information:
Can you move the padding from the right of the icon to the right of the element containing the icon and the contact information? Reference Jon's mock in Slack (bdash-company)

@wbprice
Copy link

wbprice commented Mar 16, 2017

The sitemap columns would look better left aligned rather than floating in the center. Reference Jon's mock.

@tjwebb tjwebb merged commit 5b1b262 into master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants