update cohere to use tool call attribute on AIMessage #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baskaryan
added a commit
to langchain-ai/langchain
that referenced
this pull request
Apr 9, 2024
core[minor], langchain[patch], openai[minor], anthropic[minor], fireworks[minor], groq[minor], mistralai[minor]
```python
class ToolCall(TypedDict):
name: str
args: Dict[str, Any]
id: Optional[str]
class InvalidToolCall(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
error: Optional[str]
class ToolCallChunk(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
index: Optional[int]
class AIMessage(BaseMessage):
...
tool_calls: List[ToolCall] = []
invalid_tool_calls: List[InvalidToolCall] = []
...
class AIMessageChunk(AIMessage, BaseMessageChunk):
...
tool_call_chunks: Optional[List[ToolCallChunk]] = None
...
```
Important considerations:
- Parsing logic occurs within different providers;
- ~Changing output type is a breaking change for anyone doing explicit
type checking;~
- ~Langsmith rendering will need to be updated:
langchain-ai/langchainplus#3561
- ~Langserve will need to be updated~
- Adding chunks:
- ~AIMessage + ToolCallsMessage = ToolCallsMessage if either has
non-null .tool_calls.~
- Tool call chunks are appended, merging when having equal values of
`index`.
- additional_kwargs accumulate the normal way.
- During streaming:
- ~Messages can change types (e.g., from AIMessageChunk to
AIToolCallsMessageChunk)~
- Output parsers parse additional_kwargs (during .invoke they read off
tool calls).
Packages outside of `partners/`:
- langchain-ai/langchain-cohere#7
- https://github.com/langchain-ai/langchain-google/pull/123/files
---------
Co-authored-by: Chester Curme <chester.curme@gmail.com>
ccurme
changed the title
ccurme
requested review from
GangGreenTemperTatum,
harry-cohere,
BeatrixCohere,
billytrend-cohere and
minjie-cohere
as code owners
harry-cohere
previously approved these changes
Apr 10, 2024
Signed-off-by: harry-cohere <127103098+harry-cohere@users.noreply.github.com>
harry-cohere
approved these changes
Apr 10, 2024
junkeon
pushed a commit
to UpstageAI/langchain
that referenced
this pull request
Apr 16, 2024
core[minor], langchain[patch], openai[minor], anthropic[minor], fireworks[minor], groq[minor], mistralai[minor]
```python
class ToolCall(TypedDict):
name: str
args: Dict[str, Any]
id: Optional[str]
class InvalidToolCall(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
error: Optional[str]
class ToolCallChunk(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
index: Optional[int]
class AIMessage(BaseMessage):
...
tool_calls: List[ToolCall] = []
invalid_tool_calls: List[InvalidToolCall] = []
...
class AIMessageChunk(AIMessage, BaseMessageChunk):
...
tool_call_chunks: Optional[List[ToolCallChunk]] = None
...
```
Important considerations:
- Parsing logic occurs within different providers;
- ~Changing output type is a breaking change for anyone doing explicit
type checking;~
- ~Langsmith rendering will need to be updated:
https://github.com/langchain-ai/langchainplus/pull/3561~
- ~Langserve will need to be updated~
- Adding chunks:
- ~AIMessage + ToolCallsMessage = ToolCallsMessage if either has
non-null .tool_calls.~
- Tool call chunks are appended, merging when having equal values of
`index`.
- additional_kwargs accumulate the normal way.
- During streaming:
- ~Messages can change types (e.g., from AIMessageChunk to
AIToolCallsMessageChunk)~
- Output parsers parse additional_kwargs (during .invoke they read off
tool calls).
Packages outside of `partners/`:
- langchain-ai/langchain-cohere#7
- https://github.com/langchain-ai/langchain-google/pull/123/files
---------
Co-authored-by: Chester Curme <chester.curme@gmail.com>
ccurme
added a commit
that referenced
this pull request
Apr 19, 2024
Langchain today released a new [tool_calls attribute](https://python.langchain.com/docs/modules/model_io/chat/function_calling/) on AIMessage, and these were supported by ChatCohere on release (see #7). Langchain also released a new function for building [tool-calling agents](https://python.langchain.com/docs/modules/agents/agent_types/tool_calling/) that is intended to work with any chat model that supports the new tool calling feature. However, it does not yet work with ChatCohere, and users will receive `ApiError: status_code: 400, body: {'message': 'invalid request: all elements in history must have a message.'}` if they attempt to use it. A typical flow of messages in this agent framework might look like this: ```python from langchain_core.messages import AIMessage, HumanMessage, ToolMessage from langchain_cohere import ChatCohere llm = ChatCohere(temperature=0) messages = [ HumanMessage(content="what is the value of magic_function(3)?"), AIMessage( content="", tool_calls=[ { "name": "magic_function", "args": {"input": 3}, "id": "d86e6098-21e1-44c7-8431-40cfc6d35590", } ], ), ToolMessage( name="magic_function", content="5", tool_call_id="d86e6098-21e1-44c7-8431-40cfc6d35590", ), ] response = llm.invoke(messages) assert isinstance(response, AIMessage) ``` This currently gives the above ApiError. Here we add support for processing tool-calling AI messages and ToolMessages (analogous to Cohere's `tool_result` field). This enables the new tool-calling agent constructor for Cohere: ```python from langchain.agents import AgentExecutor, create_tool_calling_agent, tool from langchain_cohere import ChatCohere from langchain_core.prompts import ChatPromptTemplate, MessagesPlaceholder prompt = ChatPromptTemplate.from_messages( [ ("system", "You are a helpful assistant"), MessagesPlaceholder("chat_history", optional=True), ("human", "{input}"), MessagesPlaceholder("agent_scratchpad"), ] ) model = ChatCohere() @tool def magic_function(input: int) -> int: """Applies a magic function to an input.""" return input + 2 @tool def get_word_length(word: str) -> int: """Returns the length of a word.""" return len(word) tools = [magic_function, get_word_length] agent = create_tool_calling_agent(model, tools, prompt) agent_executor = AgentExecutor(agent=agent, tools=tools, verbose=True) agent_executor.invoke( { "input": ( "what is the value of magic_function(3)? " "also, what is the length of the word 'pumpernickel'?" ) } ) ``` ``` > Entering new AgentExecutor chain... Invoking: `magic_function` with `{'input': 3}` 5 Invoking: `get_word_length` with `{'word': 'pumpernickel'}` 12The value of `magic_function(3)` is 5 and the length of the word 'pumpernickel' is 12. > Finished chain. {'input': "what is the value of magic_function(3)? also, what is the length of the word 'pumpernickel'?", 'output': "The value of `magic_function(3)` is 5 and the length of the word 'pumpernickel' is 12."} ``` ### Requests: - If you have test cases for `cohere_agent.create_cohere_tools_agent`, please supply them so I can compare functionality. - Please review the `_get_tool_results` function and my changes to the composition of `chat_history` to ensure they make sense. - Please voice any other feedback or concerns. Thank you! --------- Signed-off-by: ccurme <chester.curme@gmail.com> Co-authored-by: harry-cohere <127103098+harry-cohere@users.noreply.github.com>
hinthornw
pushed a commit
to langchain-ai/langchain
that referenced
this pull request
Apr 26, 2024
core[minor], langchain[patch], openai[minor], anthropic[minor], fireworks[minor], groq[minor], mistralai[minor]
```python
class ToolCall(TypedDict):
name: str
args: Dict[str, Any]
id: Optional[str]
class InvalidToolCall(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
error: Optional[str]
class ToolCallChunk(TypedDict):
name: Optional[str]
args: Optional[str]
id: Optional[str]
index: Optional[int]
class AIMessage(BaseMessage):
...
tool_calls: List[ToolCall] = []
invalid_tool_calls: List[InvalidToolCall] = []
...
class AIMessageChunk(AIMessage, BaseMessageChunk):
...
tool_call_chunks: Optional[List[ToolCallChunk]] = None
...
```
Important considerations:
- Parsing logic occurs within different providers;
- ~Changing output type is a breaking change for anyone doing explicit
type checking;~
- ~Langsmith rendering will need to be updated:
langchain-ai/langchainplus#3561
- ~Langserve will need to be updated~
- Adding chunks:
- ~AIMessage + ToolCallsMessage = ToolCallsMessage if either has
non-null .tool_calls.~
- Tool call chunks are appended, merging when having equal values of
`index`.
- additional_kwargs accumulate the normal way.
- During streaming:
- ~Messages can change types (e.g., from AIMessageChunk to
AIToolCallsMessageChunk)~
- Output parsers parse additional_kwargs (during .invoke they read off
tool calls).
Packages outside of `partners/`:
- langchain-ai/langchain-cohere#7
- https://github.com/langchain-ai/langchain-google/pull/123/files
---------
Co-authored-by: Chester Curme <chester.curme@gmail.com>
Anirudh31415926535
added a commit
to Anirudh31415926535/langchain-cohere-fork
that referenced
this pull request
Jul 30, 2024
* support streaming for tool calling * nit * Add streaming for tool call * nit * replace cassettes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.