Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vertex to use tool call attribute on AIMessage #123

Merged
merged 8 commits into from
Apr 10, 2024
Merged

update vertex to use tool call attribute on AIMessage #123

merged 8 commits into from
Apr 10, 2024

Conversation

ccurme
Copy link
Contributor

@ccurme ccurme commented Apr 8, 2024

No description provided.

@ccurme ccurme mentioned this pull request Apr 8, 2024
Merged
@ccurme ccurme changed the title (WIP) update vertex to use tool call attribute on AIMessage update vertex to use tool call attribute on AIMessage Apr 10, 2024
@ccurme ccurme marked this pull request as ready for review April 10, 2024 12:19
@ccurme ccurme requested a review from efriis April 10, 2024 12:25
efriis
efriis approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix some of the streaming issues?

@ccurme
Copy link
Contributor Author

ccurme commented Apr 10, 2024

Does this also fix some of the streaming issues?

not that I know of...

@efriis efriis merged commit 22c2056 into main Apr 10, 2024
13 checks passed
@efriis efriis deleted the cc/tool_calls_msg branch April 10, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccurme @efriis