Add optional id_field to VertexRank #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
reviewed
May 13, 2024
|
/gcbrun |
|
@shenghann linter is red |
lkuligin
reviewed
May 14, 2024
lkuligin
approved these changes
May 14, 2024
|
@shenghann you can run linter locally with |
lkuligin
approved these changes
May 15, 2024
lkuligin
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are valid use cases to retain the
idfield in the original retrieved documents in the documents that are reranked byVertexRank. This is especially important for use cases where traceability of documents throughout the chain is important.Current assigned
idbased on an enumerated incrementing index works for cases whereids do not need to be tracked but isn't universally applicable.