Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return type for GoogleGenerativeAIEmbeddings #248

Merged
merged 4 commits into from
May 23, 2024
Merged

fix return type for GoogleGenerativeAIEmbeddings #248

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f017ae
fix return type for GoogleGenerativeAIEmbeddings
adamvig96 May 22, 2024
70836ca
Add test for return type of GoogleGenerativeAIEmbeddings
adamvig96 May 23, 2024
a1b1e43
Merge branch 'main' into main
adamvig96 May 23, 2024
782b895
fix lint
adamvig96 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/genai/langchain_google_genai/embeddings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def embed_documents(
)
except Exception as e:
raise GoogleGenerativeAIError(f"Error embedding content: {e}") from e
return [e.values for e in result.embeddings]
return [list(e.values) for e in result.embeddings]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind also adding / fixing an integration test, please?


def embed_query(
self,
Expand Down
7 changes: 6 additions & 1 deletion libs/genai/tests/integration_tests/test_embeddings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def test_embed_query_different_lengths(query: str) -> None:
model = GoogleGenerativeAIEmbeddings(model=_MODEL)
result = model.embed_query(query)
assert len(result) == 768
assert isinstance(result, list)


@pytest.mark.parametrize(
Expand All @@ -35,6 +36,7 @@ async def test_aembed_query_different_lengths(query: str) -> None:
model = GoogleGenerativeAIEmbeddings(model=_MODEL)
result = await model.aembed_query(query)
assert len(result) == 768
assert isinstance(result, list)


def test_embed_documents() -> None:
Expand All @@ -46,6 +48,8 @@ def test_embed_documents() -> None:
assert len(result) == 2
assert len(result[0]) == 768
assert len(result[1]) == 768
assert isinstance(result, list)
assert isinstance(result[0], list)


async def test_aembed_documents() -> None:
Expand All @@ -57,7 +61,8 @@ async def test_aembed_documents() -> None:
assert len(result) == 2
assert len(result[0]) == 768
assert len(result[1]) == 768

assert isinstance(result, list)
assert isinstance(result[0], list)

def test_invalid_model_error_handling() -> None:
"""Test error handling with an invalid model name."""
Expand Down
Loading