vertexai[patch]: support model param
#81
Conversation
lkuligin
force-pushed
the
bagatur/support_model_param
branch
4 times, most recently
from
bf56160
to
8b6122f
Compare
lkuligin
force-pushed
the
bagatur/support_model_param
branch
from
8b6122f
to
5ddc4f0
Compare
| @@ -55,6 +55,12 @@ class _VertexAIBase(BaseModel): | |||
| model_name: Optional[str] = None | |||
| "Underlying model name." | |||
|
|
|||
| @root_validator(pre=True) | |||
There was a problem hiding this comment.
should we add an @property for model as well?
There was a problem hiding this comment.
do you know any use case when it's actually consumed by any chaiins or other "external" instances?
if model property is commonly used outside the LLM/ChatModel itself, maybe we should actually deprecate model_name then.
There was a problem hiding this comment.
do you know any use case when it's actually consumed by any chaiins or other "external" instances? if
modelproperty is commonly used outside the LLM/ChatModel itself, maybe we should actually deprecatemodel_namethen.
I think we should use model_name to stay consistent with other provider.
See this issue
#81
@lkuligin @efriis
There was a problem hiding this comment.
I'll merge this one as is then, and we can add another property later if we decide so.
Related to langchain-ai/langchain#18975
Didn't go the usual pydantic
Field(..., alias="model")route because that would've caused mypy errors for anyone passing inmodel_name(ie for all existing code).