x

langchain-ai · Jun 10, 2024 · 82f14ba · 82f14ba
1 parent 73d16ea
commit 82f14ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 18 deletions.
diff --git a/langchain_postgres/vectorstores.py b/langchain_postgres/vectorstores.py
@@ -1074,6 +1074,11 @@ def _handle_field_filter(
                             f"Unsupported type: {type(val)} for value: {val}"
                         )
 
+                    if isinstance(val, bool):  # b/c bool is an instance of int
+                        raise NotImplementedError(
+                            f"Unsupported type: {type(val)} for value: {val}"
+                        )
+
             queried_field = self.EmbeddingStore.cmetadata[field].astext
 
             if operator in {"$in"}:

diff --git a/tests/unit_tests/fixtures/filtering_test_cases.py b/tests/unit_tests/fixtures/filtering_test_cases.py
@@ -218,24 +218,6 @@
         {"id": {"$nin": [1, 2]}},
         [3],
     ),
-    # With boolean fields
-    (
-        {"is_active": {"$in": [True]}},
-        [1, 3],
-    ),
-    (
-        {"is_active": {"$nin": [True]}},
-        [2],
-    ),
-    # With null fields
-    (
-        {"happiness": {"$in": [None]}},
-        [3],
-    ),
-    (
-        {"happiness": {"$nin": [None]}},
-        [1, 2],
-    ),
 ]
 
 TYPE_5_FILTERING_TEST_CASES = [