add unit tests for $in and $nin operators (#67)

Add unit tests for $in and $nin operators
langchain-ai · Jun 10, 2024 · f724ab3 · f724ab3
1 parent e02d730
commit f724ab3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/langchain_postgres/vectorstores.py b/langchain_postgres/vectorstores.py
@@ -1109,6 +1109,11 @@ def _handle_field_filter(
                             f"Unsupported type: {type(val)} for value: {val}"
                         )
 
+                    if isinstance(val, bool):  # b/c bool is an instance of int
+                        raise NotImplementedError(
+                            f"Unsupported type: {type(val)} for value: {val}"
+                        )
+
             queried_field = self.EmbeddingStore.cmetadata[field].astext
 
             if operator in {"$in"}:

diff --git a/tests/unit_tests/fixtures/filtering_test_cases.py b/tests/unit_tests/fixtures/filtering_test_cases.py
@@ -203,11 +203,21 @@
         {"name": {"$in": ["adam", "bob"]}},
         [1, 2],
     ),
+    # With numeric fields
+    (
+        {"id": {"$in": [1, 2]}},
+        [1, 2],
+    ),
     # Test nin
     (
         {"name": {"$nin": ["adam", "bob"]}},
         [3],
     ),
+    ## with numeric fields
+    (
+        {"id": {"$nin": [1, 2]}},
+        [3],
+    ),
 ]
 
 TYPE_5_FILTERING_TEST_CASES = [