IMPROVEMENT: filter global warnings properly (#13754)

langchain-ai · Nov 23, 2023 · 72c108b · 72c108b
1 parent 163bf16
commit 72c108b
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/libs/core/langchain_core/globals/__init__.py b/libs/core/langchain_core/globals/__init__.py
@@ -27,7 +27,7 @@ def set_verbose(value: bool) -> None:
             warnings.filterwarnings(
                 "ignore",
                 message=(
-                    "Importing verbose from langchain_core root module is no longer supported"
+                    "Importing verbose from langchain root module is no longer supported"
                 ),
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's
@@ -55,7 +55,7 @@ def get_verbose() -> bool:
             warnings.filterwarnings(
                 "ignore",
                 message=(
-                    "Importing verbose from langchain_core root module is no longer supported"
+                    ".*Importing verbose from langchain root module is no longer supported"
                 ),
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's
@@ -87,7 +87,7 @@ def set_debug(value: bool) -> None:
         with warnings.catch_warnings():
             warnings.filterwarnings(
                 "ignore",
-                message="Importing debug from langchain_core root module is no longer supported",
+                message="Importing debug from langchain root module is no longer supported",
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's
             #       module-level `__getattr__()` implementation:
@@ -113,7 +113,7 @@ def get_debug() -> bool:
         with warnings.catch_warnings():
             warnings.filterwarnings(
                 "ignore",
-                message="Importing debug from langchain_core root module is no longer supported",
+                message="Importing debug from langchain root module is no longer supported",
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's
             #       module-level `__getattr__()` implementation:
@@ -145,7 +145,7 @@ def set_llm_cache(value: Optional["BaseCache"]) -> None:
             warnings.filterwarnings(
                 "ignore",
                 message=(
-                    "Importing llm_cache from langchain_core root module is no longer supported"
+                    "Importing llm_cache from langchain root module is no longer supported"
                 ),
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's
@@ -173,7 +173,7 @@ def get_llm_cache() -> "BaseCache":
             warnings.filterwarnings(
                 "ignore",
                 message=(
-                    "Importing llm_cache from langchain_core root module is no longer supported"
+                    "Importing llm_cache from langchain root module is no longer supported"
                 ),
             )
             # N.B.: This is a workaround for an unfortunate quirk of Python's

diff --git a/libs/langchain/tests/unit_tests/test_globals.py b/libs/langchain/tests/unit_tests/test_globals.py
@@ -1,6 +1,27 @@
+import warnings
+
+from langchain_core.globals import get_debug as core_get_debug
+from langchain_core.globals import get_verbose as core_get_verbose
+from langchain_core.globals import set_debug as core_set_debug
+from langchain_core.globals import set_verbose as core_set_verbose
+
 from langchain.globals import get_debug, get_verbose, set_debug, set_verbose
 
 
+def test_no_warning() -> None:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+
+        get_debug()
+        set_debug(False)
+        get_verbose()
+        set_verbose(False)
+        core_get_debug()
+        core_set_debug(False)
+        core_get_verbose()
+        core_set_verbose(False)
+
+
 def test_debug_is_settable_directly() -> None:
     from langchain_core.callbacks.manager import _get_debug