Dockerfile issues when trying to build the repo using .devcontainer

[SavvasMohito]

System Info

Hello, after forking and cloning the repo on my machine, I tried to open it using docker and specifically in VS Code with the option to "Reopen in Container". While building, the final command of dev.Dockerfile resulted in the following error:

#0 1.241 Directory ../core does not exist

After investigating, I found out that the issue lies in pyproject.toml which is using relative paths like ../core and ../community in some occasions. Additionally, even after replacing ../ with libs/ (which I am not sure if it breaks something else), the actual core and community directories are never copied over in dev.Dockerfile. These should also be copied in the created docker container, similarly to line 41.

After making these two changes, the container was successfully built. I'll check out whether the change of paths in pyproject.toml is affecting any other files, and if not I will create a PR for this.

Who can help?

No response

Information

• The official example notebooks/scripts
• My own modified scripts

Related Components

• LLMs/Chat Models
• Embedding Models
• Prompts / Prompt Templates / Prompt Selectors
• Output Parsers
• Document Loaders
• Vector Stores / Retrievers
• Memory
• Agents / Agent Executors
• Tools / Toolkits
• Chains
• Callbacks/Tracing
• Async

Reproduction

Steps to reproduce:

1. Fork and clone the repo on your machine
2. Open it with VS Code (with Dev Containers extension installed)
3. Run the VS Code command: "Dev Containers: Rebuild Container"

Expected behavior

Build the development docker container without errors

[dosubot]

🤖

It's great to hear that you were able to identify the issue and come up with a solution for the Dockerfile problem. Your initiative to fix the relative paths in pyproject.toml and ensure that the core and community directories are properly copied over in the dev.Dockerfile is commendable.

Creating a pull request with your proposed changes would be a valuable contribution to the LangChain project. It's important to ensure that the changes don't affect any other files, as you mentioned. Once you've confirmed that, feel free to proceed with creating the PR.

Thank you for your willingness to contribute to LangChain! If you have any further questions or need assistance with the PR creation process, feel free to ask.

---

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[aduston]

@SavvasMohito I just ran into the same issue. Are you planning on making a pull request? Thanks!

[SavvasMohito]

Hi @aduston, yes I'll have a look at it this week and try to come up with a PR. Thanks for reminding me 😄