Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in VectorStoreQATool and VectorStoreQAWithSourcesTool #18460

Closed
5 tasks done
alex-ber opened this issue Mar 3, 2024 · 0 comments · Fixed by #18529
Closed
5 tasks done

Regression in VectorStoreQATool and VectorStoreQAWithSourcesTool #18460

alex-ber opened this issue Mar 3, 2024 · 0 comments · Fixed by #18529
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: vector store Related to vector store module

Comments

@alex-ber
Copy link

alex-ber commented Mar 3, 2024

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangChain rather than my code.
  • The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

;

Error Message and Stack Trace (if applicable)

Root cause:
AttributeError: 'CallbackManager' object has no attribute 'ignore_chain'

`
Traceback (most recent call last):
File "/var/lang/lib/python3.10/site-packages/langchain_core/callbacks/manager.py", line 255, in handle_event
if ignore_condition_name is None or not getattr(
AttributeError: 'CallbackManager' object has no attribute 'ignore_chain'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/var/lang/lib/python3.10/site-packages/langchain_core/runnables/base.py", line 2075, in invoke
input = step.invoke(
File "/var/lang/lib/python3.10/site-packages/langchain_core/runnables/base.py", line 4069, in invoke
return self.bound.invoke(
File "/var/lang/lib/python3.10/site-packages/langchain/chains/base.py", line 163, in invoke
raise e
File "/var/lang/lib/python3.10/site-packages/langchain/chains/base.py", line 153, in invoke
self._call(inputs, run_manager=run_manager)
File "/var/lang/lib/python3.10/site-packages/langchain/agents/agent.py", line 1391, in _call
next_step_output = self._take_next_step(
File "/var/lang/lib/python3.10/site-packages/langchain/agents/agent.py", line 1097, in _take_next_step
[
File "/var/lang/lib/python3.10/site-packages/langchain/agents/agent.py", line 1097, in
[
File "/var/lang/lib/python3.10/site-packages/langchain/agents/agent.py", line 1182, in _iter_next_step
yield self._perform_agent_action(
File "/var/lang/lib/python3.10/site-packages/langchain/agents/agent.py", line 1204, in _perform_agent_action
observation = tool.run(
File "/var/lang/lib/python3.10/site-packages/langchain_core/tools.py", line 419, in run
raise e
File "/var/lang/lib/python3.10/site-packages/langchain_core/tools.py", line 376, in run
self._run(*tool_args, run_manager=run_manager, **tool_kwargs)
File "/var/lang/lib/python3.10/site-packages/langchain_community/tools/vectorstore/tool.py", line 57, in _run
return chain.invoke(
File "/var/lang/lib/python3.10/site-packages/langchain/chains/base.py", line 145, in invoke
run_manager = callback_manager.on_chain_start(
File "/var/lang/lib/python3.10/site-packages/langchain_core/callbacks/manager.py", line 1296, in on_chain_start
handle_event(
File "/var/lang/lib/python3.10/site-packages/langchain_core/callbacks/manager.py", line 285, in handle_event
if handler.raise_error:
AttributeError: 'CallbackManager' object has no attribute 'raise_error'
`

Description

Patch #16949 introduced breaking change.
See my comment their #16949 (comment)

System Info

bash-4.2# python -m langchain_core.sys_info

System Information

OS: Linux
OS Version: #1 SMP Thu Oct 5 21:02:42 UTC 2023
Python Version: 3.10.13 (main, Dec 4 2023, 13:30:46) [GCC 7.3.1 20180712 (Red Hat 7.3.1-17)]

Package Information

langchain_core: 0.1.28
langchain: 0.1.10
langchain_community: 0.0.25
langsmith: 0.1.10
langchain_experimental: 0.0.50
langchain_openai: 0.0.2.post1
langchain_text_splitters: 0.0.1

Packages not installed (Not Necessarily a Problem)

The following packages were not found:

langgraph
langserve

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 3, 2024
@alex-ber alex-ber changed the title Breaking change in VectorStoreQATool Regression in VectorStoreQATool Mar 4, 2024
cbornet added a commit to cbornet/langchain that referenced this issue Mar 4, 2024
cbornet added a commit to cbornet/langchain that referenced this issue Mar 4, 2024
@alex-ber alex-ber changed the title Regression in VectorStoreQATool Regression in VectorStoreQATool and VectorStoreQAWithSourcesTool Mar 5, 2024
thebhulawat pushed a commit to thebhulawat/langchain that referenced this issue Mar 6, 2024
bechbd pushed a commit to bechbd/langchain that referenced this issue Mar 29, 2024
gkorland pushed a commit to FalkorDB/langchain that referenced this issue Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant