Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runnable astream_log does not pass kwargs to _astream_log_implementation #19054

Closed
5 tasks done
rere950303 opened this issue Mar 14, 2024 · 0 comments
Closed
5 tasks done

Runnable astream_log does not pass kwargs to _astream_log_implementation #19054

rere950303 opened this issue Mar 14, 2024 · 0 comments
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: Runnables Related to Runnables

Comments

@rere950303
Copy link
Contributor

rere950303 commented Mar 14, 2024 •
edited

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangChain rather than my code.
  • The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

pass

Error Message and Stack Trace (if applicable)

No response

Description

When calling the _stream_log_implementation from the astream_log method in the Runnable class, it is not handing over the kwargs argument. Therefore, even if i want to customize APIHandler and implement additional features with additional arguments, it is not possible. Conversely, the astream_events method normally handing over the kwargs argument.

System Info

pass
@rere950303 rere950303 mentioned this issue Mar 14, 2024
Merged
@dosubot dosubot bot added Ɑ: Runnables Related to Runnables 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 14, 2024
eyurtsev pushed a commit that referenced this issue Mar 14, 2024
@rere950303
core: Runnable pass kwargs to _astream_log_implementation in astream_…
69a8ef2 
…log (#19055)

- **Description:** When calling the `_stream_log_implementation` from
the `astream_log` method in the `Runnable` class, it is not handing over
the `kwargs` argument. Therefore, even if i want to customize APIHandler
and implement additional features with additional arguments, it is not
possible. Conversely, the `astream_events` method normally handing over
the `kwargs` argument.
- **Issue:** #19054
- **Dependencies:**
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!

Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
rahul-trip pushed a commit to daxa-ai/langchain that referenced this issue Mar 27, 2024
@rere950303 @rahul-trip
core: Runnable pass kwargs to _astream_log_implementation in astream_…
f2aec47 
…log (langchain-ai#19055)

- **Description:** When calling the `_stream_log_implementation` from
the `astream_log` method in the `Runnable` class, it is not handing over
the `kwargs` argument. Therefore, even if i want to customize APIHandler
and implement additional features with additional arguments, it is not
possible. Conversely, the `astream_events` method normally handing over
the `kwargs` argument.
- **Issue:** langchain-ai#19054
- **Dependencies:**
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!

Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
bechbd pushed a commit to bechbd/langchain that referenced this issue Mar 29, 2024
@rere950303
core: Runnable pass kwargs to _astream_log_implementation in astream_…
560e6ad 
…log (langchain-ai#19055)

- **Description:** When calling the `_stream_log_implementation` from
the `astream_log` method in the `Runnable` class, it is not handing over
the `kwargs` argument. Therefore, even if i want to customize APIHandler
and implement additional features with additional arguments, it is not
possible. Conversely, the `astream_events` method normally handing over
the `kwargs` argument.
- **Issue:** langchain-ai#19054
- **Dependencies:**
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!

Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
gkorland pushed a commit to FalkorDB/langchain that referenced this issue Mar 30, 2024
@rere950303 @gkorland
core: Runnable pass kwargs to _astream_log_implementation in astream_…
acda35a 
…log (langchain-ai#19055)

- **Description:** When calling the `_stream_log_implementation` from
the `astream_log` method in the `Runnable` class, it is not handing over
the `kwargs` argument. Therefore, even if i want to customize APIHandler
and implement additional features with additional arguments, it is not
possible. Conversely, the `astream_events` method normally handing over
the `kwargs` argument.
- **Issue:** langchain-ai#19054
- **Dependencies:**
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!

Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
hinthornw pushed a commit that referenced this issue Apr 26, 2024
@rere950303 @hinthornw
core: Runnable pass kwargs to _astream_log_implementation in astream_…
1aa4f14 
…log (#19055)

- **Description:** When calling the `_stream_log_implementation` from
the `astream_log` method in the `Runnable` class, it is not handing over
the `kwargs` argument. Therefore, even if i want to customize APIHandler
and implement additional features with additional arguments, it is not
possible. Conversely, the `astream_events` method normally handing over
the `kwargs` argument.
- **Issue:** #19054
- **Dependencies:**
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!

Co-authored-by: hyungwookyang <hyungwookyang@worksmobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: Runnables Related to Runnables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyurtsev @rere950303