Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: <Issue related to /v0.2/docs/how_to/tools_prompting/> fix import in example code #21814

Closed
2 tasks done
maccam912 opened this issue May 17, 2024 · 2 comments
Closed
2 tasks done

DOC: <Issue related to /v0.2/docs/how_to/tools_prompting/> fix import in example code #21814

maccam912 opened this issue May 17, 2024 · 2 comments
Labels
Ɑ: core Related to langchain-core 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder

Comments

@maccam912
Copy link
Contributor

Checklist

  • I added a very descriptive title to this issue.
  • I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:

The first code block on https://python.langchain.com/v0.2/docs/how_to/tools_prompting/#creating-our-prompt has
from langchain.tools.render import render_text_description
this did not work for me, I got an error that I didn't have the module "langchain". I fixed it by changing that line to
from langchain_core.tools import render_text_description
instead.

Idea or request for content:

Change from langchain.tools.render import render_text_description to from langchain_core.tools import render_text_description on https://python.langchain.com/v0.2/docs/how_to/tools_prompting/#creating-our-prompt
@maccam912
Copy link
Contributor Author

https://github.com/langchain-ai/langchain/blob/master/docs/docs/how_to/tools_prompting.ipynb?short_path=f4ea763#L165

@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 17, 2024
@maccam912 maccam912 mentioned this issue May 17, 2024
Merged
hwchase17 pushed a commit that referenced this issue May 17, 2024
@maccam912
langchain: Fixing import in docs per #21814 (#21815)
e59afe2 
Description: The example in the How-To guide had an import which did not
work. I changed it to use an import from langchain_core.

Issue: #21814
@baskaryan
Copy link
Collaborator

thank you for flagging and fixing @maccam912!

jeromechoo pushed a commit to jeromechoo/langchain that referenced this issue May 20, 2024
@maccam912
langchain: Fixing import in docs per langchain-ai#21814 (langchain-ai…
5278667 
…#21815)

Description: The example in the How-To guide had an import which did not
work. I changed it to use an import from langchain_core.

Issue: langchain-ai#21814
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this issue May 23, 2024
@maccam912 @JuHyung-Son
langchain: Fixing import in docs per langchain-ai#21814 (langchain-ai…
c8504ae 
…#21815)

Description: The example in the How-To guide had an import which did not
work. I changed it to use an import from langchain_core.

Issue: langchain-ai#21814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ɑ: core Related to langchain-core 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maccam912 @baskaryan