-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize docstrings and improve coverage #21983
Labels
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
help wanted
Good issue for contributors
Comments
I will start! |
4 tasks
baskaryan
pushed a commit
that referenced
this issue
May 22, 2024
Thank you for contributing to LangChain! - [X] **PR title**: "docs: Chroma docstrings update" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [X] **PR message**: - **Description:** Added and updated Chroma docstrings - **Issue:** #21983 - [X] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - only docs - [X] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
JuHyung-Son
pushed a commit
to JuHyung-Son/langchain
that referenced
this issue
May 23, 2024
Thank you for contributing to LangChain! - [X] **PR title**: "docs: Chroma docstrings update" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [X] **PR message**: - **Description:** Added and updated Chroma docstrings - **Issue:** langchain-ai#21983 - [X] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - only docs - [X] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
1 task
baskaryan
added a commit
that referenced
this issue
Jun 4, 2024
- [x] **PR title**: Update docstrings for OpenAI base.py -**Description:** Updated the docstring of few OpenAI functions for a better understanding of the function. - **Issue:** #21983 --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
1 task
hinthornw
pushed a commit
that referenced
this issue
Jun 20, 2024
Thank you for contributing to LangChain! - [X] **PR title**: "docs: Chroma docstrings update" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [X] **PR message**: - **Description:** Added and updated Chroma docstrings - **Issue:** #21983 - [X] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - only docs - [X] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
hinthornw
pushed a commit
that referenced
this issue
Jun 20, 2024
- [x] **PR title**: Update docstrings for OpenAI base.py -**Description:** Updated the docstring of few OpenAI functions for a better understanding of the function. - **Issue:** #21983 --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
eyurtsev
added a commit
that referenced
this issue
Jul 11, 2024
- **Description:** Add SQLChatMessageHistory docstring. - **Issue:** the issue #21983 Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
ccurme
added a commit
that referenced
this issue
Jul 23, 2024
- **Description:** Add `RedisChatMessageHistory ` rich docstrings. - **Issue:** the issue #21983 Co-authored-by: ccurme <chester.curme@gmail.com>
ccurme
pushed a commit
that referenced
this issue
Jul 24, 2024
- **Description:** Add MongoDBChatMessageHistory rich docstrings. - **Issue:** the issue #21983
ccurme
pushed a commit
that referenced
this issue
Jul 25, 2024
- **Description:** Standardize BaichuanTextEmbeddings docstrings. - **Issue:** the issue #21983
ccurme
pushed a commit
that referenced
this issue
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
help wanted
Good issue for contributors
Issue
Every public module, class, method and attribute should have a docstring.
Requirements
NOTE!
RST code block must have a newline between
.. code-block:: python
and the code example, and code example must be tabbed, to render correctly!Examples
Module
langchain/foo/__init__.py
Class and attributes
Not Pydantic class
NOTE
If the object attributes and init args are the same then you can just document the init args for non-Pydantic classes and just document the attributes for Pydantic classes.
Pydantic class
Function/method
The text was updated successfully, but these errors were encountered: