Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use _additional fields while executing a Weaviate query #5072

Closed
jettro opened this issue May 21, 2023 · 0 comments · Fixed by #5085
Closed

Add option to use _additional fields while executing a Weaviate query #5072

jettro opened this issue May 21, 2023 · 0 comments · Fixed by #5085

Comments

@jettro
Copy link
Contributor

jettro commented May 21, 2023

Feature request

Weaviate has the option to pass _additional field while executing a query
https://weaviate.io/developers/weaviate/api/graphql/additional-properties

It would be good to be able to use this feature and add the response to the results. It is a small change, without breaking the API. We can use the kwargs argument, similar to where_filter in the python class weaviate.py.

Motivation

When comparing and understanding query results, using certainty is a good way.

Your contribution

I like to contribute to the PR. As it would be my first contribution, I need to understand the integration tests and build the project, and I already tested the change in my local code sample.
jettro added a commit to jettro/langchain-weaviate-additional that referenced this issue May 22, 2023
@jettro
Fixes issue langchain-ai#5072 - adds additional support to Weaviate
f9bf64f 
Implementation is similar to search_distance and where_filter
@dev2049 dev2049 mentioned this issue May 22, 2023
Merged
jettro added a commit to jettro/langchain-weaviate-additional that referenced this issue May 22, 2023
@jettro
Fixes issue langchain-ai#5072 - adds additional support to Weaviate
25b6fd4 
Add the additional part also to the vector based query
jettro added a commit to jettro/langchain-weaviate-additional that referenced this issue May 22, 2023
@jettro
Fixes issue langchain-ai#5072 - improve integration test
80c0d4e
dev2049 added a commit that referenced this issue May 23, 2023
@jettro @dev2049
Fixes issue #5072 - adds additional support to Weaviate (#5085)
b950022 
Implementation is similar to search_distance and where_filter

# adds 'additional' support to Weaviate queries

Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
vowelparrot pushed a commit that referenced this issue May 24, 2023
@jettro @dev2049 @vowelparrot
Fixes issue #5072 - adds additional support to Weaviate (#5085)
1a3e468 
Implementation is similar to search_distance and where_filter

# adds 'additional' support to Weaviate queries

Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@danielchalef danielchalef mentioned this issue Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue #5072 - adds additional support to Weaviate jettro/langchain-weaviate-additional
1 participant
@jettro