Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3DirectoryLoader exception #10193

Merged
merged 1 commit into from Sep 4, 2023

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 4, 2023

#9304 introduced a critical bug. The S3DirectoryLoader fails completely because boto3 checks the naming of kw arguments and one of the args is badly named (very sorry for that)

cc @baskaryan

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2023 5:57pm
langchain-deprecated ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2023 5:57pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 4, 2023
@cbornet
Copy link
Collaborator Author

cbornet commented Sep 4, 2023

cc @baskaryan @hwchase17

@baskaryan baskaryan merged commit f389c4f into langchain-ai:master Sep 4, 2023
32 checks passed
@cbornet cbornet deleted the fix-s3-dirloader branch September 5, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: doc loader Related to document loader module (not documentation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants