Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supabase vector self querying retriever #10304

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Supabase vector self querying retriever #10304

merged 7 commits into from
Sep 7, 2023

Conversation

gregnr
Copy link
Contributor

@gregnr gregnr commented Sep 7, 2023

Description

Adds Supabase Vector as a self-querying retriever.

  • Designed to be backwards compatible with existing filter logic on SupabaseVectorStore.
  • Adds new filter postgrest_filter to SupabaseVectorStore similarity_search() methods
  • Supports entire PostgREST filter query language (used by self-querying retriever, but also works as an escape hatch for more query control)
  • SupabaseVectorTranslator converts Langchain filter into the above PostgREST query
  • Adds Jupyter Notebook for the self-querying retriever
  • Adds tests

Tag maintainer

@hwchase17

Twitter handle

@ggrdson

@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 6:23pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Sep 7, 2023
@baskaryan baskaryan added the 🔌: supabase Primarily related to Supabase integrations label Sep 7, 2023
baskaryan
baskaryan reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two quick questions but otherwise lgtm! thanks @gregnr!!

libs/langchain/langchain/retrievers/self_query/supabase.py Outdated Show resolved Hide resolved
libs/langchain/langchain/retrievers/self_query/supabase.py Outdated Show resolved Hide resolved
libs/langchain/langchain/retrievers/self_query/supabase.py Show resolved Hide resolved
@baskaryan
Copy link
Collaborator

happy to resolve test/linting issues if you'd like

@gregnr
Copy link
Contributor Author

gregnr commented Sep 7, 2023 •
edited
Loading

Thanks @baskaryan! Test/linting seems to be okay now but let me know if there is anything I'm missing. Thanks for the feedback as well. Would love to get your thoughts on CONTAIN as discussed

Edit: I'm seeing some failed tests now on specific Python versions - will take a look

@gregnr
Copy link
Contributor Author

gregnr commented Sep 7, 2023

Update: Fixed tests failing on v3.11 + linting errors

@baskaryan
Copy link
Collaborator

🚀

@baskaryan baskaryan merged commit 3005596 into langchain-ai:master Sep 7, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan left review comments

Assignees
No one assigned
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features 🔌: supabase Primarily related to Supabase integrations Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregnr @baskaryan