Add progress bar + runner fixes #10348
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
hinthornw
force-pushed
the
wfh/progress_bar
branch
from
f2c106a
to
2b892dd
Compare
| from threading import Lock | ||
|
|
||
|
|
||
| class ProgressBar: |
There was a problem hiding this comment.
Btw we have tqdm as a transitive dependency already courtesy of openai sdk
There was a problem hiding this comment.
Oh that's even nicer. I almost never run into scenarios where people don't have tqdm so i'll just use that, just didn't want to add another requirement
There was a problem hiding this comment.
Hm actually just gonna keep the print method since it works and pbar kept not erasing (i can swap out later if we want)
| if verbose: | ||
| try: | ||
| agg_feedback = results.get_aggregate_feedback() | ||
| print("\n Eval quantiles:") |
There was a problem hiding this comment.
Why use print for some things and logger for others?
There was a problem hiding this comment.
Hm mainlyformatting? default logging configs have a prefix that makes it less pretty to view. The error messaging with logging seems right for actually reporting errors (especially since i then don't have to handle threading)
There was a problem hiding this comment.
Can switch at some point if we want
hinthornw
force-pushed
the
wfh/progress_bar
branch
from
a3daa60
to
7f28c56
Compare
Closes LS-902