Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comments in output format #11536

Conversation

shankinson
Copy link
Contributor

@shankinson shankinson commented Oct 8, 2023

  • Description: Fixes the comments in the ConvoOutputParser. Because the \\ is escaping a single \, they render something like: "action_input": string \ The input to the action in the prompt. Changing this to \\\\ lets it escape two slashes so that it renders a proper comment: "action_input": string \\ The input to the action
  • Issue: N/A
  • Dependencies:
  • Tag maintainer: @hwchase17
  • Twitter handle:

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2023 9:54pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Oct 8, 2023
@baskaryan
Copy link
Collaborator

great catch, thanks @shankinson!

@baskaryan baskaryan merged commit 447a523 into langchain-ai:master Oct 9, 2023
32 checks passed
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
- **Description:** Fixes the comments in the ConvoOutputParser. Because
the \\\\ is escaping a single \\, they render something like:
`"action_input": string \ The input to the action` in the prompt.
Changing this to \\\\\\\\ lets it escape two slashes so that it renders
a proper comment: `"action_input": string \\ The input to the action`
  - **Issue:** N/A
  - **Dependencies:** 
  - **Tag maintainer:** @hwchase17
  - **Twitter handle:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: agent Related to agents module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants