Bug fix tongyi.py to be compatible with DashScope API #11956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input parameter "prompt", and update parameter name "api_key".
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
verlocks
changed the title
eyurtsev
reviewed
Oct 19, 2023
| message_dicts, params = self._create_message_dicts(messages, stop) | ||
|
|
||
| if message_dicts[-1]['role'] != 'user': |
There was a problem hiding this comment.
Why is this restriction needed? Does the API error when the last message is not user or does it return something?
There was a problem hiding this comment.
Yes, if the last message is not user, the API will return this:
which doesn't give an explicit reason.
eyurtsev
added
the
lgtm
hoanq1811
pushed a commit
to hoanq1811/langchain
that referenced
this pull request
Feb 2, 2024
…1956) Current ChatTongyi is not compatible with DashScope API, which will cause error when passing api key to chat model directly. - **Description:** Update tongyi.py to be compatible with DashScope API. Specifically, update parameter name "dashscope_api_key" to "api_key". - **Issue:** None. - **Dependencies:** Nothing new, Tongyi would require DashScope as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ChatTongyi is not compatible with DashScope API, which will cause error when passing api key to chat model directly.