New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI check that integration tests compile #12090
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 change, otherwise lgtm
.github/workflows/_test.yml
Outdated
@@ -38,12 +38,16 @@ jobs: | |||
|
|||
- name: Install dependencies | |||
shell: bash | |||
run: poetry install | |||
run: poetry install --with=test_integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should install these extras after the core tests finish. I think there's a few unit tests to confirm that importing without the extra deps installed doesn't crash (only using objects does) - e.g. test_dependencies.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great pt
No description provided.